Add @Nullable to ScrollView getChildVisibleRect offset parameter#57075
Open
cortinico wants to merge 1 commit into
Open
Add @Nullable to ScrollView getChildVisibleRect offset parameter#57075cortinico wants to merge 1 commit into
cortinico wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@cortinico has exported this pull request. If you are a Meta employee, you can view the originating Diff in D107507935. |
meta-codesync
Bot
changed the title
cortinico
force-pushed
the
export-D107507935
branch
from
d984dea to
9376eb4
Compare
meta-codesync
Bot
changed the title
cortinico
force-pushed
the
export-D107507935
branch
from
9376eb4 to
315acb8
Compare
meta-codesync
Bot
changed the title
cortinico
added a commit
to cortinico/react-native
that referenced
this pull request
Jun 4, 2026
…ebook#57075) Summary: The `offset` parameter in `getChildVisibleRect` overrides was missing the `Nullable` annotation. The Android framework contract for `ViewGroup.getChildVisibleRect(View, Rect, Point)` allows `offset` to be null, and `View.getGlobalVisibleRect(Rect)` legitimately passes null. The `Nullsafe` instrumentation injected a non-null assertion that crashed when null was passed. Changelog: [Android][Fixed] - Fix NullPointerException in ScrollView `getChildVisibleRect` when `offset` is null Reviewed By: javache Differential Revision: D107507935
cortinico
force-pushed
the
export-D107507935
branch
from
315acb8 to
ba43ae9
Compare
Summary: The `offset` parameter in `getChildVisibleRect` overrides was missing the `Nullable` annotation. The Android framework contract for `ViewGroup.getChildVisibleRect(View, Rect, Point)` allows `offset` to be null, and `View.getGlobalVisibleRect(Rect)` legitimately passes null. The `Nullsafe` instrumentation injected a non-null assertion that crashed when null was passed. Changelog: [Android][Fixed] - Fix NullPointerException in ScrollView `getChildVisibleRect` when `offset` is null Reviewed By: javache Differential Revision: D107507935
meta-codesync
Bot
changed the title
cortinico
force-pushed
the
export-D107507935
branch
from
ba43ae9 to
f70abcd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The
offsetparameter ingetChildVisibleRectoverrides was missing theNullableannotation. The Android framework contract forViewGroup.getChildVisibleRect(View, Rect, Point)allowsoffsetto be null,and
View.getGlobalVisibleRect(Rect)legitimately passes null. TheNullsafeinstrumentation injected a non-null assertion that crashed when null was passed.
Changelog:
[Android][Fixed] - Fix NullPointerException in ScrollView
getChildVisibleRectwhenoffsetis nullReviewed By: javache
Differential Revision: D107507935